Skip to content

[Feature] Improve logging for error messages #22599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Feature] Improve logging for error messages #22599

wants to merge 1 commit into from
+2,023 −92

Conversation

elizabetht
Copy link

@elizabetht elizabetht commented Aug 10, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Run all tests

python -m pytest tests/v1/engine/test_initialization_errors.py -v

Run specific test class

python -m pytest tests/v1/engine/test_initialization_errors.py::TestInsufficientMemoryError -v

For demo purposes

python vllm/v1/engine/enhanced_error_demo.py

Test Result

(Optional) Documentation Update

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation v1 labels Aug 10, 2025
@elizabetht elizabetht mentioned this pull request Aug 10, 2025
Open
1 task
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 10, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive error handling and logging mechanism for vLLM V1 initialization. It defines new specific exception classes for common issues like insufficient memory and model loading failures, providing users with detailed error messages and actionable suggestions. The changes are well-structured and significantly improve the debugging experience. I've found one critical issue related to a potential ZeroDivisionError that could crash the application during initialization under certain edge cases.

@elizabetht elizabetht force-pushed the feature/improve-logging-for-error-messages branch 2 times, most recently from df50b07 to 9f8a0f9 Compare August 10, 2025 20:54
DarkLight1337
DarkLight1337 reviewed Aug 11, 2025
View reviewed changes
@elizabetht elizabetht force-pushed the feature/improve-logging-for-error-messages branch 3 times, most recently from da69cf6 to d1b9f49 Compare August 11, 2025 18:04
@elizabetht elizabetht force-pushed the feature/improve-logging-for-error-messages branch from d1b9f49 to 5208c90 Compare August 11, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 left review comments

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizabetht @DarkLight1337